Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PA Messages quick fix #792

Merged
merged 3 commits into from
Jul 1, 2024
Merged

PA Messages quick fix #792

merged 3 commits into from
Jul 1, 2024

Conversation

PaulJKim
Copy link
Collaborator

@PaulJKim PaulJKim commented Jul 1, 2024

Summary of changes

Asana Ticket: RTS: Trigger PA Message Readouts

Missed a change to bus audio that I needed to merge into the pa-messages branch. This PR is a hotfix to fix the compile error.

@PaulJKim PaulJKim requested a review from a team as a code owner July 1, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Coverage of commit d939664

Summary coverage rate:
  lines......: 73.6% (2110 of 2867 lines)
  functions..: 75.8% (583 of 769 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/bus.ex                                           |84.0%    307|95.7%    47|    -      0

Download coverage report

panentheos
panentheos approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, then looks good.

lib/signs/bus.ex Outdated Show resolved Hide resolved
PaulJKim and others added 2 commits July 1, 2024 11:05
@PaulJKim PaulJKim merged commit 555b8c5 into main Jul 1, 2024
2 checks passed
@PaulJKim PaulJKim deleted the pk/pa-message-hotfix branch July 1, 2024 15:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Coverage of commit 594f992

Summary coverage rate:
  lines......: 73.6% (2110 of 2867 lines)
  functions..: 75.8% (583 of 769 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/bus.ex                                           |84.0%    307|95.7%    47|    -      0

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

@panentheos panentheos panentheos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulJKim @panentheos @sloanelybutsurely